minutes of ESC call ...

* Present:
    + Kendy, Miklos, Sophie, Christian, Michael S, Michael M, Eike, Lionel,
      Heiko, Olivier, Caolan, Stephan, Thorsten, Xisco, Tamas B

* Completed Action Items:

* Pending Action Items:

* Release Engineering update (Christian)
    + no releases planned this week.
    + 6.0.5 – RC2
        + early next week
    + 6.1.0 beta 2 next week …
        + was optional, but worth having near end of week.
    + 6.1 late features
        + calc threading default / fixing (Miklos)
           + ongoing – more fixes this week.
        + writer – red-lining re-factoring (Michael S)
           + doesn’t quite work yet, but want to get it into master soon
              + get it in tomorrow, and continue later to finish it
              + expect another couple of weeks until it can be enabled
                in experimental mode.
           + desirable to get it into 6.1 (Thorsten)
              + have kill-switch to turn it off
           + lets get it into master & decide next week wrt. 6.1
        + Help format (Stephan)
           + various make file dependency fixes
        + Get-involved info-bar & Help/About menu (Kendy)
           + plan to get it before next ESC.
        + flat MIME icons (Andreas K)
           + https://bugs.documentfoundation.org/show_bug.cgi?id=117456
           + https://gerrit.libreoffice.org/#/c/54990/
           + documentation team informed
    + Renewed the Windows certificate for another year (watch out QA).
       + everything working nicely.
    + Remotes
        + iOS remote pending Apple’s approval.
    + Android viewer
    + Online
        + up-loaded a beta1

* Documentation (Olivier)
    + New Help
        + Fixes in Makefiles for media (thanks to Stephan Bergman)
        + Tweaks in UI CSS (Adolfo Barrientos)
        + Fix <switchinline> in XSLT
    + Help contents
        + New Pages for MAXIFS, MINIFS, (ohallot)
        + refactoring of ‘IFS functions (ohallot)
            + reduces workload for translation
        + files cleanups and visual enhancements (S Schröder)
        + Fixes and typos (Adolfo, ohallot)
        + Master vs 6.1: backport help pages?, New Help?
            + no approval needed yet (Michael)
    + Guides and Books
        + Further reviews on GS 6.0 chapters by Jean Weber
        + Assembling book on going (ohallot)
        + spent some days in São Paulo with the local team

* UX Update (Heiko)
    + Bugzilla (topicUI) statistics
        247(247) (topicUI) bugs open, 309(309) (needsUXEval)
    + Updates:
        BZ changes 1 week 1 month 3 months 12 months
             added 2(1) 3(-4) 25(-8) 99(-4)
         commented 10(2) 56(-54) 409(-52) 1812(-78)
           removed 0(0) 0(0) 2(0) 11(0)
          resolved 1(-1) 5(0) 29(-2) 177(-3)
    + top 10 contributors:
          Tietze, Heiko made 28 changes in 1 month, and 795 changes in 1 year
          Xisco Faulí made 13 changes in 1 month, and 333 changes in 1 year
          Thomas Lendo made 12 changes in 1 month, and 381 changes in 1 year
          Kainz, Andreas made 9 changes in 1 month, and 26 changes in 1 year
          Pedro made 8 changes in 1 month, and 25 changes in 1 year
          Ilhan Yesil made 7 changes in 1 month, and 10 changes in 1 year
          Timur made 7 changes in 1 month, and 59 changes in 1 year
          Foote, V Stuart made 5 changes in 1 month, and 265 changes in 1 year
          Cor Nouws made 4 changes in 1 month, and 153 changes in 1 year
          A.Holtsmark made 4 changes in 1 month, and 8 changes in 1 year
  + Guideline for floating widgets
    + should clearly identified as detachable, stay on top,
      close on escape, look like a tool-window
    + https://wiki.documentfoundation.org/Design/Selection#Appearance

  + Keyboard shortcut to move cols/rows in Calc
    + Proposal via mode switch; enable a different / movement mode (?)
    + surely WYSIWYG editors try to avoid modes ? (Michael)

  + Mojave dark mode request (tdf#118017)

* Fuzz / Crash Testing (Caolan)
    + 10(+4) import failures, 9(+6) export failures
        + 2 exports – mst layout asserts.
        + expect related to Bitmap / threading changes.
    + coverity
        + 3 (+0, -13)
    + forcepoint round 7.
        + 11 docs → 4 root issues.
        + 1 outstanding
           + a hang – intractable layout loop
    + oss-fuzz ?? (15 outstanding, 12 minor, lots of font cache unreproducibles)
        + lots of irreproducible ones.

* Crash Reporting (Xisco)
    + http://crashreport.libreoffice.org/stats/version/5.4.6.2
          + 547 (last 7 days) (-177)
    + http://crashreport.libreoffice.org/stats/version/5.4.7.2
          + 489 (last 7 days) (+149)

    + http://crashreport.libreoffice.org/stats/version/6.0.3.2
          + 993(last 7 days) (-174)
    + http://crashreport.libreoffice.org/stats/version/6.0.4.2
          + 1793 (last 7 days) (+565)

    + Top 1 crash: MultiSalLayout::AdjustLayout(ImplLayoutArgs &)
          + https://bugs.documentfoundation.org/show_bug.cgi?id=114736
            + Fixed in master https://cgit.freedesktop.org/libreoffice/core/commit/?id=9b5730f92967b6a8f4fce349bcd951f388b940df
          + Backport abandoned ???
      + https://gerrit.libreoffice.org/#/c/49033/
          + ticket is abandoned (?)
              + coming up with a new one (Tamas)

* PDFium bits (Kendy)
   + perhaps you noticed a chunk of PDF work landing on master
      + from Ashod
   + year ago Miklos added embedding PDF as a meta-file
      + you get a bitmap in the document.
      + but resulting PDF (and/or PDF print) contains vectors.
   + new feature – in online or when export a variable
      + import of PDF – does this too.
      + opening a PDF – get bitmaps for each page; 100% as in chromium
         + try to save it → get PDF data.
   + not editable out of the box.
      + can ‘break’ it → similar to the SVG code.
      + decomposes it into text & shapes & bitmaps etc.
      + not 100% perfect yet the decomposition
         + so disabled by default.
   + hope that we can get it better than poppler soon.
      + then switch the default; looks beautiful
         – and is editable on breaking
      + other pages you don’t want to edit stay the same.
      + using the PDF data behind the scenes.
   + small change for the user – currently directly see editable form
      + show an info-bar to hint – use ‘break’ etc. (?)
   + thoughts ? Questions ?
   + can there be a blog to help documentation ? (Olivier)
      + will ask Ash (Kendy)
   + may be some some overlap with SVG multi-page (Thorsten)
      + open in draw vs. impress – with animations etc.
      + same story as with PDF – high quality graphic, then break.
      + underlying data-structures, the same (Kendy)
      + breaking itself – different code-paths
      + we directly de-compose the shapes from PDF rather than meta-files …
      + Armin ↔ Ash talk to each other.

* Alpha bitmap plan (Michael)
   + … skip next time ...

* Budget ranking (Thorsten)
   + on ESC share - “Budget2018” - add your ranking.
   + please rank stuff ...

* GSoC schedule (Heiko)
   + Coding: May 14 - August 6
       + please tell students to send a weekly status update.
       + apparently going well ...
   + Evaluation 1: June 11 - 15
   + Evaluation 2: July 9 - 13
   + Students Submit Code and Final Evaluations: August 6 - 14
   + Mentors Submit Final Evaluations: August 14 - 21
   + Results Announced: August 22
   + https://wiki.documentfoundation.org/Development/GSoC/2018

* Hackfests & Events
   + working on a Munich event end of October (Thorsten)
      + an Open Gov’t meeting from the City of Munich
      + good to have a hack-fest back-to-back there.
   + potentially one in Switzerland later in the year / November
   + call for papers for the LibreOffice Conference still ongoing! (Sophie)
      + deadline: mid-July

* mentoring/easyhack update
          committer... 1 week 1 month 3 months 12 months
                  open 55(-28) 107(-31) 114(-32) 117(-32)
               reviews 588(10) 1812(93) 4768(50) 17952(-86)
                merged 309(62) 1130(91) 3537(40) 13303(61)
             abandoned 16(3) 140(5) 273(-3) 953(5)
           own commits 341(95) 1227(69) 3637(33) 13498(47)
        review commits 64(1) 290(-3) 893(-19) 3097(4)
        contributor... 1 week 1 month 3 months 12 months
                  open 48(-16) 84(-10) 86(-10) 90(-10)
               reviews 947(105) 2938(85) 8405(-134) 31596(114)
                merged 34(15) 106(10) 385(-24) 1729(0)
             abandoned 14(12) 36(5) 113(2) 389(9)
           own commits 33(10) 113(7) 354(-8) 1194(5)
        review commits 0(0) 0(0) 0(0) 0(0)
    + easyHack statistics:
       needsDevEval 46(46) needsUXEval 2(2) cleanup_comments 205(205)
       total 255(255) assigned 25(25) open 180(180)
    + top 5 contributors:
          Gelmini, Andrea made 47 patches in 1 month, and 368 patches in 1 year
          Sophia Schröder made 10 patches in 1 month, and 49 patches in 1 year
          Jim Raykowski made 8 patches in 1 month, and 64 patches in 1 year
          Samuel Thibault made 7 patches in 1 month, and 34 patches in 1 year
          Justin Luth made 5 patches in 1 month, and 5 patches in 1 year
    + top 5 reviewers:
          Pootle bot made 330 review comments in 1 month, and 1764 in 1 year
          Behrens, Thorsten made 212 review comments in 1 month, and 1485 in 1 year
          Adolfo Jayme Barrientos made 127 review comments in 1 month, and 688 in 1 year
          Grandin, Noel made 113 review comments in 1 month, and 1476 in 1 year
          Holešovský, Jan made 106 review comments in 1 month, and 1199 in 1 year
    + big CONGRATULATIONS to contributors who have at least 1 merged patch, since last report:
          Fred Kruse f.kruse@freenet.de
          Ilhan Yesil ilhanyesil@gmx.de
* Commit Access

* Developer Certification (Stephan/Bjoern/Kendy/Thorsten)
    + have 2 names → no concerns.

* Jenkins / CI update (Christian)
    master linux rel jobs: 149 ok: 149 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    master linux dbg jobs: 62 ok: 61 ko: 1 fail ratio: 1.61 % break: 1 broken duration: 0.02%
    master mac rel jobs: 115 ok: 112 ko: 3 fail ratio: 2.61 % break: 3 broken duration: 0.62%
    master mac dbg jobs: 120 ok: 117 ko: 3 fail ratio: 2.50 % break: 3 broken duration: 0.73%
    master win rel jobs: 55 ok: 38 ko: 17 fail ratio: 30.91 % break: 13 broken duration:40.74%
    master win dbg jobs: 68 ok: 51 ko: 17 fail ratio: 25.00 % break: 9 broken duration:30.11%
    master win64 dbg jobs: 60 ok: 44 ko: 16 fail ratio: 26.67 % break: 12 broken duration:22.32%
    lo-5.3 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    lo-5.4 mac jobs: 0 ok: 0 ko: 0 fail ratio: 0.00 % break: 0 broken duration: 0.00%
    master gerrit lin jobs: 409 ok: 304 ko: 20 fail ratio: 4.89% time for ok: mean: 13 median: 11
    master gerrit plg jobs: 416 ok: 296 ko: 41 fail ratio: 9.86% time for ok: mean: 31 median: 30
    master gerrit win jobs: 415 ok: 294 ko: 30 fail ratio: 7.23% time for ok: mean: 61 median: 53
    master gerrit mac jobs: 407 ok: 287 ko: 42 fail ratio: 10.32% time for ok: mean: 56 median: 40
    master gerrit all jobs: 355 ok: 213 ko: 105 fail ratio: 29.58% time for ok: mean: 105 median: 94
  + failure breakdown: https://dev-www.libreoffice.org/tmp/gerrit_180607.html
      1 icontheme
      1 make,infra
      1 python,tests
      2 cosmetic
      4 junit,tests
      6 uitest,tests
      7 unknown
     15 infra
     28 compiler
     41 cppunit,tests
   + 14 times CppunitTest_sw_layoutwriter on mac
      – likely issue with resolution of a single machine
     + infra failures happen in rapid succession – not so serious.
     + cppunit – are they random ? (Michael)
        + pretty random (Christian)
        + would like to know which test from the suite (Miklos)
            + in the logs: SwLayoutWriter::testTableExtrusion1()
     + this is from the Jenkins page / build-history.
     + also looked at Windows build / CPU
        + total time ~50mins
          + 5 minutes at the begin – checkout/dep gen.
          + 8 min in middle & end – just 1 CPU core.
          + 20mins – with just 1 core.
        + so should run concurrent builds to make better use of 32 threads
        + want to enable it in Jenkins for real builds.

* l10n (Sophie)
    + work is ongoing …

* HSQLDB migration Wizard (Lionel)
   + from Bugzilla – impression we shouldn’t push this ‘on’ by default
      + agree with this – keep it disabled for now.
   => disable auto-migration for now except for experimental (Tamas B)

* QA update (Xisco)

    + UNCONFIRMED: 501 (-8)
        + enhancements: 55 (-2)
        + needsUXEval: 0 (-1)
        + haveBackTrace: 6 (+1)
        + needsDevAdvice: 28 (-1)
        + documentation: 0 (+0)
        + android: 10 (-1)
   + Most Pressing Bugs: http://tdf.io/mostressingbugs

        + New
    [None]

        + Older
            + EDITING: Crash while selecting cell format with double-click
                + https://bugs.documentfoundation.org/show_bug.cgi?id=115950
                + Kendy ? The commit was reverted…

            + CRASH: LibreOffice crashes if the sidebar is empty
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117920
                + Bubli ?

            + Writer crashes every time with a certain large file FILEOPEN
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117723
                + Bjoern writer re-factor

            + Crash when undoing the pasting of a table
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117749
                + Bjoern writer re-factor

            + EDITING: crash in SfxItemSet::GetItemState pasting comment
              of closed document
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117228
                + Henry Castro doing ongoing work on it.

            + Crash (fatal error) when attempting a mail merge print
                + https://bugs.documentfoundation.org/show_bug.cgi?id=116543
                + Szymon ?

            + CRASH: Print Preview crashes on signed document without infobar
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117426
                + Bubli (has fix for 5.4.x)

            + Firebird: Migration: Migration function must recognize opening...
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117531
    
        + Fixed:

            + Crash in: ScInputHandler::EnterHandler(ScEnterMode)
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117824
                + fixed thanks to Caolan

            + LO61b1: On macOS in Impress slide show does not run full screen
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117872
                + fixed thanks to Tor

            + Crash when cutting an 3d object in Draw
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117984
                + fixed thanks to Armin

            + Crash in: `anonymous namespace'::documentStartPageNumber
                + https://bugs.documentfoundation.org/show_bug.cgi?id=116527
                + fixed thanks to Caolán

            + [GTK3] Crash in welded "Tab color" dialog.
                + https://bugs.documentfoundation.org/show_bug.cgi?id=117859
                + fixed thanks to Caolán

* QA stats

   + https://bugs.documentfoundation.org/page.cgi?id=weekly-bug-summary.html
      +139 -8 (-200) overall)
      many thanks to the top bug squashers:
       QA Administrators 87
       Xisco Faulí 22
       Buovjaga 14
       Caolán McNamara 8
       Heiko Tietze 7
       Mike Kaganski 5
       V Stuart Foote 5
       m.a.riosv 4
       Thomas Lendo 4
       Adolfo Jayme 3

    + top 10 bugs reporters:
       Telesto 7
       Xisco Faulí 6
       Aron Budea 6
       Luke 5
       Samuel Mehrbrodt (CIB) 4
       Balint Fodor 3
       Thomas Lendo 2
       Martin Terry 2
       kompilainenn 2
       Hidenori Ozaki 2

    + top 10 bugs fixers:
       McNamara, Caolán 8
       Lillqvist, Tor 3
       Xisco Faulí 2
       Patrick Jaap 2
       Olivier Hallot 2
       Mehrbrodt, Samuel 2
       Adolfo Jayme Barrientos 2
       Tietze, Heiko 2
       Buovjaga 2
                               1

    + top 10 bugs confirmers:
       Xisco Faulí 56
       UNKNOWN 13
       Alex Thurgood 12
       Raal 10
       Nabet, Julien 7
       Faure, Jean-Baptiste 4
       Budea, Áron 4
       Tietze, Heiko 3
       Foote, V Stuart 3
       Thomas Lendo 2

* Highest-Priority bugs (aka "MABs"):
   + http://bit.ly/2lJAAJI
     6.0 : 5/42 - 11 % (+0)
     5.4 : 2/38 - 5 % (+0)
     5.3 : 1/53 - 1 % (+0)
     5.2 : 1/41 - 2 % (+0)
     5.1 : 0/35 - 0 % (+0)
     5.0 : 2/63 - 3 % (+0)
     4.4 : 1/76 - 1 % (+0)
     4.3 : 5/74 - 6 % (+0)
     4.2 : 5/134 - 3 % (+0)
     4.1 : 3/84 - 3 % (+0)
     4.0 : 4/83 - 4 % (+0)
     old : 19/257 - 7 % (+0)

* Bisected bugs open: keyword 'bisected'
   + more accurate - down to a single commit.
   + http://bit.ly/2dyIfDy
   + 519/2225 505/2194 497/2178 505/2169 502/2152 495/2129 489/2108

     done by:
        Xisco Faulí 21
        Buovjaga 5
        Telesto 2
        Raal 1
        Budea, Áron 1

* Bibisected bugs open: keyword 'bibisected'
   + http://bit.ly/2cSCXlS
   + 630/2873 607/2832 599/2813 606/2804 599/2784 592/2760 589/2738

     done by:
        Xisco Faulí 23
        Buovjaga 8
        Telesto 3
        Budea, Áron 3
        Muhammet Kara 2
        Raal 1
        Foote, V Stuart 1

* all bugs tagged with 'regression'
   + 958(+11) bugs open of 7154(+38) total 16(+0) high prio.

     done by:
        Xisco Faulí 24
        Telesto 4
        Raal 2
        Benes, Luke 2
        Buovjaga 2
        MM 1
        Madero, Joel 1
        Alex Thurgood 1
        Budea, Áron 1
        Clemens Eisserer 1

* ~Component count net * high severity regressions
   + http://bit.ly/1HWHb3E
     Writer - 6(+0)
     Calc - 4(+0)
     LibreOffice - 3(+1)
     Impress - 2(-1)
     framework - 1(+0)

   by OS:
     All - 12(+0)
     Mac OS X - 0(+0)
     Linux - 2(+0)
     Windows - 2(+0)

* ~Component count net * all regressions
   + http://bit.ly/1BUdI8i
     Writer: other - 205(+9)
     Calc - 166(+1)
     Impress - 108(-4)
     Writer: docx filter - 79(+2)
     LibreOffice - 70(+0)
     UI - 46(+3)
     Writer: doc filter - 36(+2)
     Draw - 36(+2)
     Crashes - 35(+3)
     Borders - 32(+1)
     graphics stack - 32(+0)
     Base - 30(-1)
     filters and storage - 28(+2)
     Writer: other filter - 26(+0)
     Writer: perf - 24(-1)
     Chart - 20(-1)
     BASIC - 17(+0)
     Printing and PDF export - 14(-3)
     framework - 5(+0)
     sdk - 2(+0)
     Linguistic - 1(+0)
     Extensions - 1(+0)
     Formula Editor - 1(+0)
     Installation - 1(+0)